Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Add component prefix to CSS variables #DS-1105 #1400

Merged
merged 4 commits into from
May 14, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the BC Breaking change label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit e14c626
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6643214f26e3cb0009a76f69
😎 Deploy Preview https://deploy-preview-1400--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 7, 2024

Coverage Status

coverage: 80.157% (-16.2%) from 96.371%
when pulling e14c626 on bc/css-variable-prefix
into c93d91d on integration/release-v2.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 I looks like it should be working :-)

@curdaj curdaj force-pushed the integration/release-v2 branch from 6212b9d to 6bafe41 Compare May 9, 2024 09:31
@crishpeen crishpeen force-pushed the bc/css-variable-prefix branch from 6d7c17c to 5ba21ac Compare May 9, 2024 11:23
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think READMEs and demos should be updated too (didn't check though).

docs/migrations/web/MIGRATION-v2.md Outdated Show resolved Hide resolved
packages/web/src/scss/helpers/text/_text.scss Show resolved Hide resolved
crishpeen added 4 commits May 14, 2024 10:30
See the CSS Variables Component Prefix section in the web
package Migration Guide to version 2.
@crishpeen crishpeen force-pushed the bc/css-variable-prefix branch from 5ba21ac to e14c626 Compare May 14, 2024 08:31
@crishpeen crishpeen merged commit ba84348 into integration/release-v2 May 14, 2024
20 checks passed
@crishpeen crishpeen deleted the bc/css-variable-prefix branch May 14, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants