Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(web-twig): Rename TabLink target prop to targetPaneId #DS-1096 #1399

Merged
merged 1 commit into from
May 14, 2024

Conversation

crishpeen
Copy link
Member

See the Tabs: TabLink target prop section in the web-twig package Migration Guide to version 3.

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, adamkudrna, pavelklibani and a team as code owners May 7, 2024 09:06
@github-actions github-actions bot added the BC Breaking change label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 0644026
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66431bdaa7c9290008dcb724
😎 Deploy Preview https://deploy-preview-1399--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 7, 2024

Coverage Status

coverage: 80.157% (-16.2%) from 96.371%
when pulling 0644026 on bc/twig-tablink-target
into 80cae41 on integration/release-v2.

@crishpeen crishpeen force-pushed the bc/twig-tablink-target branch from 2481eb2 to a1bb97d Compare May 7, 2024 11:15
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curdaj curdaj force-pushed the integration/release-v2 branch from 6212b9d to 6bafe41 Compare May 9, 2024 09:31
@crishpeen crishpeen requested a review from curdaj as a code owner May 9, 2024 09:31
@crishpeen crishpeen force-pushed the bc/twig-tablink-target branch from a1bb97d to 9e0b9f5 Compare May 9, 2024 11:21
@crishpeen crishpeen force-pushed the bc/twig-tablink-target branch from 9e0b9f5 to de14b85 Compare May 14, 2024 08:00
… #DS-1096

See the Tabs: TabLink `target` Prop section in the web-twig
package Migration Guide to version 3.
@crishpeen crishpeen force-pushed the bc/twig-tablink-target branch from de14b85 to 0644026 Compare May 14, 2024 08:07
@crishpeen crishpeen merged commit c93d91d into integration/release-v2 May 14, 2024
27 checks passed
@crishpeen crishpeen deleted the bc/twig-tablink-target branch May 14, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants