-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: The alert role has been removed for Alert component #DS-1175 #1398
BREAKING CHANGE: The alert role has been removed for Alert component #DS-1175 #1398
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job 👍
Sorry, still a draft, but it is looking good. |
.../web-twig/src/Resources/components/Alert/__tests__/__snapshots__/alertDefault.twig.snap.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
6212b9d
to
6bafe41
Compare
e9d31ed
to
a78c9e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
a3c246b
to
041ba6d
Compare
As per our contributing guidelines, the commit message should go like this:
or
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
#### Migration Guide | ||
|
||
In cases where you need to use the component as an information that requires the user's immediate attention, | ||
you can use `role="alert"` as an [additional attributes][readme-additional-attributes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use `role="alert"` as an [additional attributes][readme-additional-attributes]. | |
you can use `role="alert"` as an [additional attribute][readme-additional-attributes]. |
#### Migration Guide | ||
|
||
In cases where you need to use the component as an information that requires the user's immediate attention, | ||
you can use `role="alert"` as an [additional attributes][readme-additional-attributes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use `role="alert"` as an [additional attributes][readme-additional-attributes]. | |
you can use `role="alert"` as an [additional attribute][readme-additional-attributes]. |
⚠️ Please pay attention to the accessibility setting when Alert is dynamically displayed. In cases where you need to use the component as an information that requires the user's immediate attention, | ||
you can set `role="alert"` as an [additional attributes][readme-additional-attributes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
⚠️ Please pay attention to the accessibility setting when Alert is dynamically displayed. In cases where you need to use the component as an information that requires the user's immediate attention, | |
you can set `role="alert"` as an [additional attributes][readme-additional-attributes]. | |
⚠️ Please pay attention to the accessibility setting when Alert is dynamically displayed. In case you need to use the component as an information that requires the user's immediate attention, | |
you can set `role="alert"` as an [additional attribute][readme-additional-attributes]. |
|
||
#### Migration Guide | ||
|
||
In cases where you need to use the component as an information that requires the user's immediate attention, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In cases where you need to use the component as an information that requires the user's immediate attention, | |
In case you need to use the component as an information that requires the user's immediate attention, |
|
||
#### Migration Guide | ||
|
||
In cases where you need to use the component as an information that requires the user's immediate attention, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In cases where you need to use the component as an information that requires the user's immediate attention, | |
In case you need to use the component as an information that requires the user's immediate attention, |
⚠️ Please pay attention to the accessibility setting when Alert is dynamically displayed. In cases where you need to use the component as an information that requires the user's immediate attention, | ||
you can set `role="alert"` as an [additional attributes][readme-additional-attributes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Please pay attention to the accessibility setting when Alert is dynamically displayed. In cases where you need to use the component as an information that requires the user's immediate attention, | |
you can set `role="alert"` as an [additional attributes][readme-additional-attributes]. | |
⚠️ Please pay attention to the accessibility setting when Alert is dynamically displayed. In case you need to use the component as an information that requires the user's immediate attention, | |
you can set `role="alert"` as an [additional attribute][readme-additional-attributes]. |
<Alert color="informative" iconName="profile" role="alert"> | ||
Message | ||
</Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the extra test case! 👍🏻
47059d2
to
28bfdc5
Compare
… component #DS-1175
…component #DS-1175
28bfdc5
to
a1e56f5
Compare
Description
Additional context
Issue reference