Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Add front to toast component #1397

Merged
merged 2 commits into from
May 14, 2024
Merged

Feat(web-react): Add front to toast component #1397

merged 2 commits into from
May 14, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented May 3, 2024 •
edited
Loading

Description

Additional context

  • Animations will be done in different task

Issue reference

web-react: Toast fronta notifikací

@pavelklibani pavelklibani self-assigned this May 3, 2024
@github-actions github-actions bot added the feature New feature or request label May 3, 2024
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 140abb0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664378c209b2c30008a1c5ce
😎 Deploy Preview https://deploy-preview-1397--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani changed the title 🚧 Feat(web-react): Add front to toast components - WIP 🚧 Feat(web-react): Add front to toast component - WIP May 3, 2024
@pavelklibani pavelklibani force-pushed the feat/ds-1209-react-toast-fronta branch from 5b323c8 to 867ef53 Compare May 9, 2024 10:32
@pavelklibani pavelklibani changed the title 🚧 Feat(web-react): Add front to toast component - WIP Feat(web-react): Add front to toast component May 10, 2024
@pavelklibani pavelklibani marked this pull request as ready for review May 10, 2024 08:28
@pavelklibani pavelklibani requested review from curdaj and a team as code owners May 10, 2024 08:28
@adamkudrna
Copy link
Contributor

Just passing by: the commit message could be improved and aligned with other packages:

Feat(web-react): Introduce stacking of the `Toast` queue #DS-1209

I hope it's more about queue than front here 🙂.

adamkudrna
adamkudrna reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏🏻 Please just make sure the features are aligned with the web package.

packages/web-react/src/components/Toast/demo/index.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/demo/index.tsx Show resolved Hide resolved
apps/web-twig-demo/yarn.lock Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/README.md Show resolved Hide resolved
packages/web-react/src/components/Toast/demo/ToastStaticToast.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/demo/ToastStaticToast.tsx Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/ds-1209-react-toast-fronta branch 2 times, most recently from fb152be to 79b7463 Compare May 13, 2024 14:04
@coveralls
Copy link

coveralls commented May 13, 2024 •
edited
Loading

Coverage Status

coverage: 79.477% (-17.4%) from 96.911%
when pulling 140abb0 on feat/ds-1209-react-toast-fronta
into 8e8a5b8 on integration/toast-queue.

@pavelklibani pavelklibani force-pushed the feat/ds-1209-react-toast-fronta branch 2 times, most recently from d4cb2e0 to 8633799 Compare May 14, 2024 08:49
@pavelklibani pavelklibani force-pushed the feat/ds-1209-react-toast-fronta branch 2 times, most recently from 6d67ac9 to 35f251f Compare May 14, 2024 12:55
@pavelklibani pavelklibani force-pushed the feat/ds-1209-react-toast-fronta branch from 35f251f to 0d7d923 Compare May 14, 2024 14:23
@pavelklibani
Feat(web-react): Introduce stacking of the Toast queue #DS-1209
3b8382a 
- Make Toast work with dynamic collapsible queue and dynamic ToastBars
- solves DS-1209
@pavelklibani
Deps(web-twig-demo): Update yarn.lock
140abb0
@pavelklibani pavelklibani force-pushed the feat/ds-1209-react-toast-fronta branch from 0d7d923 to 140abb0 Compare May 14, 2024 14:44
@pavelklibani pavelklibani merged commit 5569d1d into integration/toast-queue May 14, 2024
13 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1209-react-toast-fronta branch May 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelklibani @adamkudrna @coveralls @literat @crishpeen