Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(web-react): Refactor types in Tabs #DS-935 #1395

Merged
merged 1 commit into from
May 7, 2024
Merged

BREAKING CHANGE(web-react): Refactor types in Tabs #DS-935 #1395

merged 1 commit into from
May 7, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented May 3, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the BC Breaking change label May 3, 2024
@netlify Netlify
Copy link

netlify bot commented May 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 159a1e9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6639ceef3047cf000834ac2d
😎 Deploy Preview https://deploy-preview-1395--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 80.418%. remained the same
when pulling e5ae8ba on bc/ds-935-fix-types-in-tabs
into a3bfba3 on integration/release-v2.

@coveralls
Copy link

coveralls commented May 3, 2024 •
edited
Loading

Coverage Status

coverage: 75.689% (-4.7%) from 80.418%
when pulling 159a1e9 on bc/ds-935-fix-types-in-tabs
into a3bfba3 on integration/release-v2.

@curdaj curdaj marked this pull request as ready for review May 3, 2024 12:13
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners May 3, 2024 12:13
@curdaj curdaj requested a review from literat May 6, 2024 13:06
literat
literat approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

@curdaj curdaj force-pushed the bc/ds-935-fix-types-in-tabs branch from 224b492 to 159a1e9 Compare May 7, 2024 06:49
@curdaj curdaj merged commit 6212b9d into integration/release-v2 May 7, 2024
13 checks passed
@curdaj curdaj deleted the bc/ds-935-fix-types-in-tabs branch May 7, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

Assignees

@curdaj curdaj

Labels
BC Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curdaj @coveralls @literat @pavelklibani