BREAKING CHANGE: Remove feature class for bordered Alert #DS-1230 #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Please also update the visual tests (when everything is running, start make test-e2e-update and it should update the screenshot for alert). When you push the updated screenshot, you can add label run visual tests to this PR to let the CI check if everything is correct.
And remove the related section from the deprecation-v2.md file in the packages/web.
curdaj
force-pushed
the
bc/ds-1230-remove-class-for-bordered-alert
branch
2 times, most recently
from
ce4767f to
1781b68
Compare
curdaj
requested review from
literat,
adamkudrna,
pavelklibani and
a team
as code owners
pavelklibani
approved these changes
Apr 30, 2024
literat
approved these changes
Apr 30, 2024
curdaj
force-pushed
the
bc/ds-1230-remove-class-for-bordered-alert
branch
from
3b50f64 to
5318486
Compare
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8919815625/artifacts/1466133616 |
curdaj
force-pushed
the
bc/ds-1230-remove-class-for-bordered-alert
branch
from
5318486 to
49f32c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference