Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-twig): Make Toast work with dynamic collapsible queue and dynamic ToastBars #DS-1223 #1372

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Feat(web-twig): Make Toast work with dynamic collapsible queue and dynamic ToastBars #DS-1223 #1372

merged 2 commits into from
Apr 30, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Apr 25, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 312bcc9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6630c118aea37b0008fa6f71
😎 Deploy Preview https://deploy-preview-1372--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Coverage Status

coverage: 75.922% (-4.1%) from 79.972%
when pulling 87a55f2 on feature/twig-toast-queue
into 86ed8a5 on integration/toast-queue.

pavelklibani
pavelklibani approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the PHP! 👍

packages/web-twig/src/Resources/components/Toast/README.md Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/__tests__/__fixtures__/toastBar.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/stories/ToastStaticToast.twig Outdated Show resolved Hide resolved
adamkudrna
adamkudrna requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are things to be fixed, but otherwise, great job! 👏🏻

packages/web-twig/tests/fixtures/test_with_symbol.svg Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Icon/Icon.twig Show resolved Hide resolved
packages/web-twig/src/Resources/components/Icon/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Icon/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Icon/README.md Outdated Show resolved Hide resolved
...ages/web-twig/src/Resources/components/Toast/__tests__/__snapshots__/toastBar.twig.snap.html Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/stories/ToastDynamicToastQueue.twig Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/stories/ToastDynamicToastQueue.twig Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/stories/ToastDynamicToastQueue.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Twig/SvgExtension.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving all this up to @literat.

adamkudrna
adamkudrna approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍🏻 Just one last thing: I'd make the template use case easier and preset anything that can be preset.

packages/web-twig/src/Resources/components/Icon/README.md Show resolved Hide resolved
packages/web-twig/src/Resources/components/Icon/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Icon/__tests__/__fixtures__/iconDefault.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Toast/stories/ToastDynamicToastQueue.twig Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feature/twig-toast-queue branch from 87a55f2 to 312bcc9 Compare April 30, 2024 09:59
@crishpeen crishpeen force-pushed the integration/toast-queue branch from 86ed8a5 to 6c1e93b Compare April 30, 2024 10:00
@crishpeen crishpeen merged commit fb395c0 into integration/toast-queue Apr 30, 2024
27 checks passed
@crishpeen crishpeen deleted the feature/twig-toast-queue branch April 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat left review comments

@pavelklibani pavelklibani pavelklibani approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani