Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps(repo): Switch from npm-run-all to npm-run-all2 fork #1337

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Apr 8, 2024

Description

  • the original library is unmaintained for more than 5 years
  • the npm-run-all2 is a maintenance fork

Additional context

https://github.com/bcomnes/npm-run-all2

Issue reference

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 5209aa5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/662108f89c1d5f0008a1c7c0

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 5209aa5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/662108f86571bd0008798de4
😎 Deploy Preview https://deploy-preview-1337--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5209aa5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/662108f83441830008777d1e
😎 Deploy Preview https://deploy-preview-1337--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 80.873%. remained the same
when pulling 5209aa5 on deps/npm-run-all2
into c347fd2 on main.

@crishpeen
Copy link
Member

Do we plan to keep this even if it is only a maintenance fork? I understand that it is better then the non-maintained one, but I would like to know if we have a plan to move somewhere else :)

@literat
Copy link
Collaborator Author

literat commented Apr 9, 2024

Do we plan to keep this even if it is only a maintenance fork? I understand that it is better then the non-maintained one, but I would like to know if we have a plan to move somewhere else :)

In this case "maintenance" means not only updates but also some development for future node compatibility and some babel issues, etc.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Anyway, do we use the --parallel flag anywhere? Because if not, I don't see a reason for using a dependency instead of writing something as simple as yarn task1 && yarn task2

@literat
Copy link
Collaborator Author

literat commented Apr 9, 2024

🙈

Anyway, do we use the --parallel flag anywhere? Because if not, I don't see a reason for using a dependency instead of writing something as simple as yarn task1 && yarn task2

web: "js:compile": "npm-run-all --aggregate-output --parallel js:compile:**",

Anyway, this is a dev dependency and it is a part of the DX. I do not want to write yarn task1 && yarn task2.
It can do much more like using asterisks * for running multiple scripts based on some kind of pattern.

@literat literat force-pushed the deps/npm-run-all2 branch from 3f1f6e5 to b4fe645 Compare April 12, 2024 09:18
  * the original library is unmaintained for more than 5 years
  * the `npm-run-all2` is a maintanance fork
  * @see: https://github.com/bcomnes/npm-run-all2
@literat literat force-pushed the deps/npm-run-all2 branch from b4fe645 to 5209aa5 Compare April 18, 2024 11:50
@literat literat merged commit b857115 into main Apr 18, 2024
35 checks passed
@literat literat deleted the deps/npm-run-all2 branch April 18, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants