Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web): Dropdown can be placed in non-scrollable Modal #DS-939 #1332

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix(web): Dropdown can be placed in non-scrollable Modal #DS-939 #1332

merged 1 commit into from
Apr 9, 2024

Conversation

adamkudrna
Copy link
Contributor

Description

Additional context

image

Issue reference

https://jira.almacareer.tech/browse/DS-939

@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 2c55428
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66159822369f39000819f36a
😎 Deploy Preview https://deploy-preview-1332--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2c55428
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66159822e2193f000830fc9a
😎 Deploy Preview https://deploy-preview-1332--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Apr 4, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 2c55428
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/66159822f04c850008f36ab3

@coveralls
Copy link

Coverage Status

coverage: 76.353% (-4.3%) from 80.646%
when pulling af6d77e on fix/dropdown-in-modal
into 2c880e6 on main.

@adamkudrna adamkudrna force-pushed the fix/dropdown-in-modal branch from af6d77e to 2c55428 Compare April 9, 2024 19:33
@adamkudrna adamkudrna changed the base branch from main to integration/dropdown-in-modal April 9, 2024 19:34
@adamkudrna adamkudrna merged commit b5ee798 into integration/dropdown-in-modal Apr 9, 2024
28 checks passed
@adamkudrna adamkudrna deleted the fix/dropdown-in-modal branch April 9, 2024 19:45
This was referenced Apr 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@literat literat literat left review comments

@pavelklibani pavelklibani pavelklibani approved these changes

Assignees

@adamkudrna adamkudrna

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamkudrna @coveralls @literat @crishpeen @pavelklibani