Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(codemods): FileuploaderAttachment codemods #1310

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

  • Renamed button-text codemod to fileuploader-prop-names
  • Updated test fixtures and tests
  • Updated README and CONTRIBUTING files

Additional context

Fix of #1303

Issue reference

DS-1142 Codemod button label -> button text v codemod balíčku

- Renamed button-text codemods to fileuploader-prop-names
- Updated test fixtures and tests
- Updated README and CONTRIBUTING

Fixing DS-1142
@pavelklibani pavelklibani self-assigned this Mar 7, 2024
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 3568293
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65e9db96fbf01a00084325a3

@github-actions github-actions bot added the bug Something isn't working label Mar 7, 2024
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 3568293
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65e9db9689903600084c7de7

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 3568293
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65e9db96bbf51200082d56da

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 3568293
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65e9db9623cece00097c4381

@coveralls
Copy link

Coverage Status

coverage: 80.078% (-16.3%) from 96.371%
when pulling 3568293 on fix/codemods-ds-1142
into 9920fbf on main.

@pavelklibani pavelklibani marked this pull request as ready for review March 8, 2024 08:52
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani merged commit ac4d7e1 into main Mar 11, 2024
21 checks passed
@pavelklibani pavelklibani deleted the fix/codemods-ds-1142 branch March 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants