Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web-react): List Deprecations in the web react package #DS-1147 #1308

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Docs(web-react): List Deprecations in the web react package #DS-1147 #1308

merged 2 commits into from
Mar 15, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested a review from adamkudrna March 7, 2024 04:35
@crishpeen crishpeen requested review from literat, pavelklibani and a team as code owners March 7, 2024 04:35
@github-actions github-actions bot added the feature New feature or request label Mar 7, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 9de72ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65f484d47e2bbd00082c06c4
😎 Deploy Preview https://deploy-preview-1308--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 9de72ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65f484d4ef5d0a00085e165d
😎 Deploy Preview https://deploy-preview-1308--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 9de72ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65f484d46bf40a00084b52c8

@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 9de72ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65f484d4a9e73200098f2dad

@coveralls
Copy link

coveralls commented Mar 7, 2024 •
edited
Loading

Coverage Status

coverage: 80.595% (+3.1%) from 77.459%
when pulling 9de72ec on feature/react-deprecations
into c8f228a on main.

@crishpeen crishpeen force-pushed the feature/react-deprecations branch from ff3d7fa to 0217fc2 Compare March 7, 2024 14:57
literat
literat approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice!

@literat literat force-pushed the feature/react-deprecations branch from b7c6a93 to 9de72ec Compare March 15, 2024 17:26
@literat literat merged commit 421f2eb into main Mar 15, 2024
29 checks passed
@literat literat deleted the feature/react-deprecations branch March 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @coveralls @literat @pavelklibani