Test/ds 980 e2e tests agains netlify builds #1306

literat · 2024-03-06T15:00:22Z

Description

Enabling visual tests to run against Netlify deploys. This PR is based on the articles below.

This PR only contains modifications of the pipeline. For the demo application see #1315.

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-980

netlify · 2024-03-06T15:00:37Z

✅ Deploy Preview for spirit-design-system-storybook ready!

Name	Link
🔨 Latest commit	`6b63e17`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-storybook/deploys/660bc5d113e9a000083dd660
😎 Deploy Preview	https://deploy-preview-1306--spirit-design-system-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-03-06T15:02:16Z

✅ Deploy Preview for spirit-design-system-validations canceled.

Name	Link
🔨 Latest commit	`6b63e17`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-validations/deploys/660bc5d1b57e4b0009603ac5

netlify · 2024-03-06T15:02:59Z

❌ Deploy Preview for spirit-design-system-demo failed. Why did it fail? →

Name	Link
🔨 Latest commit	`e615994`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-demo/deploys/66044ea0dee969000845f460

netlify · 2024-03-06T15:04:16Z

❌ Deploy Preview for spirit-design-system-react failed. Why did it fail? →

Name	Link
🔨 Latest commit	`e615994`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-react/deploys/66044e9f5179140007934564

coveralls · 2024-03-06T15:08:42Z

coverage: 77.605% (-3.0%) from 80.602%
when pulling 6b63e17 on test/DS-980-e2e-tests-agains-netlify-builds
into 04d0fb1 on main.

github-actions · 2024-03-11T16:57:59Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8236461944/artifacts/playwright-report

github-actions · 2024-03-11T17:38:49Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8237099051/artifacts/playwright-report

netlify · 2024-03-15T12:19:55Z

✅ Deploy Preview for spirit-design-system ready!

Name	Link
🔨 Latest commit	`6b63e17`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system/deploys/660bc5d1e0a5fb00085e2cf6
😎 Deploy Preview	https://deploy-preview-1306--spirit-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 Accessibility: 93 Best Practices: 100 SEO: 82 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-03-15T12:22:38Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8296036474/artifacts/playwright-report

github-actions · 2024-03-15T12:50:42Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8296390496/artifacts/playwright-report

github-actions · 2024-03-15T13:12:07Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8296682020/artifacts/playwright-report

github-actions · 2024-03-15T15:24:30Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8298502751/artifacts/playwright-report

github-actions · 2024-03-18T12:54:30Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8326840940/artifacts/playwright-report

github-actions · 2024-03-18T13:00:51Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8326952065/artifacts/playwright-report

github-actions · 2024-03-18T13:08:05Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8327057716/artifacts/playwright-report

refs #DS-980

github-actions · 2024-03-27T17:38:40Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8455873269/artifacts/1363994457

github-actions · 2024-03-27T18:27:39Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8456766884/artifacts/1364154003

literat · 2024-03-27T19:34:33Z

link to the report is now downloadable ✅
waiting to deploy is working ✅
testing is done against the deploy ✅

literat · 2024-03-27T19:38:21Z

Remove last commit when rebasing after ✅ Approve

packages/web-react/src/components/Alert/demo/AlertColors.tsx

packages/web-twig/src/Resources/components/Alert/stories/AlertColors.twig

.github/workflows/e2e.yml

github-actions · 2024-03-28T09:58:12Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8465243955/artifacts/1366129840

crishpeen · 2024-03-28T14:35:19Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8465243955/artifacts/1366129840

According to this, all tests failed :D

However, there is a green checkmark in checks 🤷

github-actions · 2024-03-28T15:06:05Z

Here is the URL of the uploaded artifact:

github-actions · 2024-03-28T16:04:52Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8469921868/artifacts/1367257295

literat · 2024-03-28T16:11:42Z

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/8469921868/artifacts/1367257295

@crishpeen In this one, only Alert fails.

literat added the run-visual-tests Runs visual regression testing on this PR label Mar 6, 2024

github-actions bot assigned literat Mar 6, 2024

literat added run-visual-tests Runs visual regression testing on this PR and removed run-visual-tests Runs visual regression testing on this PR labels Mar 6, 2024

literat force-pushed the test/DS-980-e2e-tests-agains-netlify-builds branch 2 times, most recently from dd8aaa9 to 060b761 Compare March 15, 2024 12:02

literat changed the base branch from main to chore/docs-app March 15, 2024 12:02

literat force-pushed the chore/docs-app branch from 11adaee to 2f3b358 Compare March 15, 2024 13:02

literat force-pushed the test/DS-980-e2e-tests-agains-netlify-builds branch from ec84376 to 8da6463 Compare March 15, 2024 13:06

literat marked this pull request as ready for review March 15, 2024 17:22

literat requested a review from a team as a code owner March 15, 2024 17:22

literat requested review from adamkudrna, crishpeen and pavelklibani March 15, 2024 17:23

literat force-pushed the test/DS-980-e2e-tests-agains-netlify-builds branch from 4c8b590 to c975de8 Compare March 18, 2024 12:49

literat added 4 commits March 27, 2024 16:58

Chore(ci): Run e2e test only when it is labeled and on every push

c328e3c

refs #DS-980

Chore(ci): Create comment with e2e tests report when failuire

ce960c3

Test(repo): Use unified demo app for visual testing

87a8eb4

Docs(ci): How to enable visual testing on your PR

79f51de

literat force-pushed the test/DS-980-e2e-tests-agains-netlify-builds branch from 68a078e to 9b221e3 Compare March 27, 2024 16:00

literat commented Mar 27, 2024

View reviewed changes

packages/web-react/src/components/Alert/demo/AlertColors.tsx Outdated Show resolved Hide resolved

crishpeen reviewed Mar 28, 2024

View reviewed changes

packages/web-twig/src/Resources/components/Alert/stories/AlertColors.twig Show resolved Hide resolved

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

crishpeen approved these changes Apr 2, 2024

View reviewed changes

literat added 8 commits April 2, 2024 10:40

Chore(ci): Add artifact download button to Slack failure message

bd0bce0

Docs(ci): How to develop and test GitHub Actions locally

4ecb044

Chore(ci): Update Playwright to v1.42.1

baba28a

Chore(demo): Fix the name of the package based on the directory

239765c

Docs(web-twig): Set danger icons in Alert component

06dacdb

Test(ci): Update Alert component snapshot due to danger icon change

034e901

Chore(ci): Use docker image directly by the step

db1d8a5

Chore(ci): Get current url of uploaded artifact from the step

ee1daca

literat force-pushed the test/DS-980-e2e-tests-agains-netlify-builds branch from be83367 to 113fcde Compare April 2, 2024 08:40

Chore(ci): Set fallback url for end2end tests when deploy failes

6b63e17

literat force-pushed the test/DS-980-e2e-tests-agains-netlify-builds branch from 113fcde to 6b63e17 Compare April 2, 2024 08:46

literat merged commit f898781 into main Apr 2, 2024
24 checks passed

literat deleted the test/DS-980-e2e-tests-agains-netlify-builds branch April 2, 2024 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test/ds 980 e2e tests agains netlify builds #1306

Test/ds 980 e2e tests agains netlify builds #1306

literat commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

coveralls commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

netlify bot commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

literat commented Mar 27, 2024

literat commented Mar 27, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024

crishpeen commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

literat commented Mar 28, 2024

Test/ds 980 e2e tests agains netlify builds #1306

Test/ds 980 e2e tests agains netlify builds #1306

Conversation

literat commented Mar 6, 2024 • edited Loading

Description

Additional context

Issue reference

netlify bot commented Mar 6, 2024 • edited Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

netlify bot commented Mar 6, 2024 • edited Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

netlify bot commented Mar 6, 2024 • edited Loading

❌ Deploy Preview for spirit-design-system-demo failed. Why did it fail? →

netlify bot commented Mar 6, 2024 • edited Loading

❌ Deploy Preview for spirit-design-system-react failed. Why did it fail? →

coveralls commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

netlify bot commented Mar 15, 2024 • edited Loading

✅ Deploy Preview for spirit-design-system ready!

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

literat commented Mar 27, 2024

literat commented Mar 27, 2024 • edited Loading

github-actions bot commented Mar 28, 2024

crishpeen commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

literat commented Mar 28, 2024

literat commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 6, 2024 •

edited

Loading

coveralls commented Mar 6, 2024 •

edited

Loading

netlify bot commented Mar 15, 2024 •

edited

Loading

literat commented Mar 27, 2024 •

edited

Loading