-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(web-react): TextArea should autoresize when mounted #1296
Merged
literat
merged 2 commits into
main
from
fix/DS-158-web-react-textarea-autoresize-on-init
Mar 8, 2024
Merged
Fix(web-react): TextArea should autoresize when mounted #1296
literat
merged 2 commits into
main
from
fix/DS-158-web-react-textarea-autoresize-on-init
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
crishpeen
approved these changes
Feb 27, 2024
Shouldn't we test it somehow? |
literat
force-pushed
the
fix/DS-158-web-react-textarea-autoresize-on-init
branch
from
March 6, 2024 09:50
3aba6ec
to
58c91cd
Compare
Some tests added. |
pavelklibani
approved these changes
Mar 6, 2024
literat
force-pushed
the
fix/DS-158-web-react-textarea-autoresize-on-init
branch
from
March 8, 2024 09:15
596266c
to
c591e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calling size adjustion when is TextArea mounted.
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1158