Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): TextArea should autoresize when mounted #1296

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 26, 2024

Description

Calling size adjustion when is TextArea mounted.

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1158

@github-actions github-actions bot added the bug Something isn't working label Feb 26, 2024
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit c591e39
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65ead71e1922eb0007a38ef3
😎 Deploy Preview https://deploy-preview-1296--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit c591e39
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65ead71edf282700073e90d7
😎 Deploy Preview https://deploy-preview-1296--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit c591e39
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65ead71e2f425700089698aa

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit c591e39
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65ead71eb2bc360008004fb5

@coveralls
Copy link

coveralls commented Feb 26, 2024

Coverage Status

coverage: 80.488% (-15.9%) from 96.371%
when pulling c591e39 on fix/DS-158-web-react-textarea-autoresize-on-init
into 9920fbf on main.

@crishpeen
Copy link
Member

Shouldn't we test it somehow?

@literat literat force-pushed the fix/DS-158-web-react-textarea-autoresize-on-init branch from 3aba6ec to 58c91cd Compare March 6, 2024 09:50
@literat
Copy link
Collaborator Author

literat commented Mar 6, 2024

Shouldn't we test it somehow?

Some tests added.

@literat literat marked this pull request as ready for review March 6, 2024 11:17
@literat literat requested review from pavelklibani and a team as code owners March 6, 2024 11:17
@literat literat force-pushed the fix/DS-158-web-react-textarea-autoresize-on-init branch from 596266c to c591e39 Compare March 8, 2024 09:15
@literat literat merged commit 4a00ca5 into main Mar 8, 2024
29 checks passed
@literat literat deleted the fix/DS-158-web-react-textarea-autoresize-on-init branch March 8, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants