Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(codemod): Introduce codemod package #1287

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@github-actions github-actions bot added the feature New feature or request label Feb 19, 2024
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 795675d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65d47d4a95d29a0008a683dc

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 795675d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65d47d4b81036d0009b610bb

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 795675d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65d47d4ab20ce200081427a9

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 795675d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65d47d4baf36ec00082c22ab

packages/codemod/README.md Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator

literat commented Feb 19, 2024

A topic for discussion: I would personally prefer naming this package in the plural, e.g. codemods instead of codemod. We have packages like analytics, icons, design-tokens and there will be more than a one codemod in this package. So I think that codemods will suit better. What do you think?

@literat
Copy link
Collaborator

literat commented Feb 19, 2024

Do not forget to set also the scope in .commitlintrc.js in the root of the repository.

@pavelklibani pavelklibani force-pushed the feat/DS-1141-codemod-package branch 2 times, most recently from eba0b1c to ab59d8b Compare February 19, 2024 15:39
@pavelklibani
Copy link
Contributor Author

pavelklibani commented Feb 19, 2024

@literat

Do not forget to set also the scope in .commitlintrc.js in the root of the repository.

Added, and lint is working now, thank you.

A topic for discussion: I would personally prefer naming this package in the plural, e.g. codemods instead of codemod. We have packages like analytics, icons, design-tokens and there will be more than a one codemod in this package. So
I think that codemods will suit better. What do you think?

Renamed to codemods, i was thinking about the same.

@pavelklibani pavelklibani force-pushed the feat/DS-1141-codemod-package branch from ab59d8b to 3db11e2 Compare February 19, 2024 17:34
@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 80.9% (-15.5%) from 96.371%
when pulling 795675d on feat/DS-1141-codemod-package
into e954642 on main.

@pavelklibani pavelklibani marked this pull request as ready for review February 19, 2024 17:55
@pavelklibani pavelklibani requested a review from a team as a code owner February 19, 2024 17:55
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good. Just two minor tweaks and we are good to go.

@pavelklibani pavelklibani force-pushed the feat/DS-1141-codemod-package branch from 3db11e2 to 795675d Compare February 20, 2024 10:22
@pavelklibani pavelklibani merged commit 5d59656 into main Feb 20, 2024
20 checks passed
@pavelklibani pavelklibani deleted the feat/DS-1141-codemod-package branch February 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants