-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable rendering Symfony Forms fields in FieldGroup
#1283
Merged
literat
merged 2 commits into
main
from
fix/enable-rendering-symfony-forms-fields-in-fieldgroup
Feb 15, 2024
Merged
Enable rendering Symfony Forms fields in FieldGroup
#1283
literat
merged 2 commits into
main
from
fix/enable-rendering-symfony-forms-fields-in-fieldgroup
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlouhak
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Feb 14, 2024
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
dlouhak
commented
Feb 15, 2024
packages/web-twig/src/Resources/components/FieldGroup/FieldGroup.twig
Outdated
Show resolved
Hide resolved
dlouhak
commented
Feb 15, 2024
packages/web-twig/src/Resources/components/FieldGroup/FieldGroup.twig
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
fix/enable-rendering-symfony-forms-fields-in-fieldgroup
branch
from
February 15, 2024 10:18
eadf2e5
to
5306559
Compare
dlouhak
requested review from
literat,
adamkudrna,
crishpeen,
pavelklibani and
a team
as code owners
February 15, 2024 10:19
dlouhak
commented
Feb 15, 2024
dlouhak
commented
Feb 15, 2024
packages/web-twig/src/Resources/components/FieldGroup/README.md
Outdated
Show resolved
Hide resolved
literat
approved these changes
Feb 15, 2024
literat
force-pushed
the
fix/enable-rendering-symfony-forms-fields-in-fieldgroup
branch
from
February 15, 2024 12:18
c2d94cb
to
24227cf
Compare
pavelklibani
approved these changes
Feb 15, 2024
Works on my machine! 🖥️ ✅ Thanks @literat and @adamkudrna for the discussion and quick handling of the issue. ❤️ |
literat
deleted the
fix/enable-rendering-symfony-forms-fields-in-fieldgroup
branch
February 15, 2024 12:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text
,Radio
or more complexAccordion
.There's something I don't understand.
form_row
orform_widget
), butform_label
is rendered! 🤯dump(block('content'))
log.block('content')
into the variabledump(_children)
log.block('content')
into the variable outside the implementationdump(_children)
and is it possible to render it – but because it was stored in a variable it was converted to astring
, soraw
filter is here to help.