Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web): Fix Sass implementation notes #1276

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

adamkudrna
Copy link
Contributor

Fix minor documentation issues introduced in #1260.

@adamkudrna adamkudrna self-assigned this Feb 13, 2024
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit b7c7126
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65d48026186ad60008f39b5c
😎 Deploy Preview https://deploy-preview-1276--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit b7c7126
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65d48026f65db60008ad56fe
😎 Deploy Preview https://deploy-preview-1276--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit b7c7126
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65d480263dc4500008d9bb50
😎 Deploy Preview https://deploy-preview-1276--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 13, 2024
@adamkudrna adamkudrna force-pushed the docs/modal-minor-fixes branch from e5ba996 to e2bef08 Compare February 13, 2024 12:09
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit b7c7126
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65d48026385dad0008e15df9

@coveralls
Copy link

coveralls commented Feb 13, 2024

Coverage Status

coverage: 71.217% (-1.8%) from 73.02%
when pulling b7c7126 on docs/modal-minor-fixes
into 28ef059 on main.

@adamkudrna adamkudrna force-pushed the docs/modal-minor-fixes branch from e2bef08 to 19d487a Compare February 15, 2024 16:01
@adamkudrna
Copy link
Contributor Author

As I was passing by, I also fixed some aria-controls ID references that incorrectly started with #.

@adamkudrna adamkudrna force-pushed the docs/modal-minor-fixes branch from 19d487a to 8a3e672 Compare February 15, 2024 16:05
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and shiny 👍

@adamkudrna adamkudrna force-pushed the docs/modal-minor-fixes branch from 8a3e672 to b7c7126 Compare February 20, 2024 10:34
@adamkudrna adamkudrna merged commit 2a7c1aa into main Feb 20, 2024
35 checks passed
@adamkudrna adamkudrna deleted the docs/modal-minor-fixes branch February 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants