Feat(web-react): Deprecate Dropdown non flow placements DS-1132 #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
pavelklibani
approved these changes
Feb 15, 2024
adamkudrna
reviewed
Feb 15, 2024
adamkudrna
force-pushed
the
feat/web-react-dropdown-deprecations
branch
from
8539191 to
f4aa004
Compare
… #DS-1132 Use flow-relative placement values instead, e.g. `top-left` is now `top-start`.
adamkudrna
force-pushed
the
feat/web-react-dropdown-deprecations
branch
from
f4aa004 to
3eba5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use flow placement values, e.g.
top-leftis nowtop-start.Description
Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123).