Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-twig): Deprecate Dropdown non flow placements DS-1132 #1273

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Feat(web-twig): Deprecate Dropdown non flow placements DS-1132 #1273

merged 1 commit into from
Feb 15, 2024

Conversation

crishpeen
Copy link
Member

Use flow placement values, e.g. top-left is now top-start.

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@github-actions github-actions bot added the feature New feature or request label Feb 8, 2024
@coveralls
Copy link

coveralls commented Feb 8, 2024 •
edited
Loading

Coverage Status

coverage: 72.818%. remained the same
when pulling f057f81 on feat/web-twig-dropdown-deprecations
into eab44eb on main.

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit f057f81
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65ce42bfc4b1c8000827636c

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit f057f81
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65ce42bf4d1f000008cef1c7

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit f057f81
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65ce42bffb69d80008b708b3

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit f057f81
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65ce42bf1cb8c90007807a5f

literat
literat approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen @adamkudrna
Feat(web-twig): Deprecate non-flow-relative placements in Dropdown …
f057f81 
…#DS-1132

Use flow-relative placement values instead, e.g. `top-left` is now `top-start`.
@adamkudrna adamkudrna force-pushed the feat/web-twig-dropdown-deprecations branch from 29b3217 to f057f81 Compare February 15, 2024 16:58
@adamkudrna adamkudrna merged commit 8e171ed into main Feb 15, 2024
35 checks passed
@adamkudrna adamkudrna deleted the feat/web-twig-dropdown-deprecations branch February 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani