-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Deprecate Dropdown non flow and modifier placement DS-1132 #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani and
a team
as code owners
February 8, 2024 14:12
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
crishpeen
force-pushed
the
feat/web-dropdown-deprecations
branch
from
February 8, 2024 14:35
ab62077
to
ac9d0b4
Compare
adamkudrna
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for rewriting the IDs!
pavelklibani
approved these changes
Feb 15, 2024
Use data attribute to set the placement now. Use flow placement values, e.g. `top-left` is now `top-start`.
adamkudrna
force-pushed
the
feat/web-dropdown-deprecations
branch
from
February 20, 2024 10:14
ac9d0b4
to
6b3a134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use data attribute to set the placement now.
Use flow placement values, e.g.
top-left
is nowtop-start
.Description
Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123
).