Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Deprecate Dropdown non flow and modifier placement DS-1132 #1271

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

crishpeen
Copy link
Member

Use data attribute to set the placement now.
Use flow placement values, e.g. top-left is now top-start.

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 6b3a134
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65d47b87fc0a890008304e6f

@github-actions github-actions bot added the feature New feature or request label Feb 8, 2024
Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 6b3a134
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65d47b875189560008491d9b
😎 Deploy Preview https://deploy-preview-1271--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 6b3a134
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65d47b87ed3adb00083ddaad

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 6b3a134
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65d47b87a886ab00082e4a14

@coveralls
Copy link

coveralls commented Feb 8, 2024

Coverage Status

coverage: 71.217% (-25.2%) from 96.371%
when pulling 6b3a134 on feat/web-dropdown-deprecations
into e954642 on main.

@crishpeen crishpeen force-pushed the feat/web-dropdown-deprecations branch from ab62077 to ac9d0b4 Compare February 8, 2024 14:35
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for rewriting the IDs!

Use data attribute to set the placement now.
Use flow placement values, e.g. `top-left` is now `top-start`.
@adamkudrna adamkudrna force-pushed the feat/web-dropdown-deprecations branch from ac9d0b4 to 6b3a134 Compare February 20, 2024 10:14
@adamkudrna adamkudrna merged commit 28ef059 into main Feb 20, 2024
29 checks passed
@adamkudrna adamkudrna deleted the feat/web-dropdown-deprecations branch February 20, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants