Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(web-react): Move away from the defaultProps #1267

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Refactor(web-react): Move away from the defaultProps #1267

merged 1 commit into from
Apr 16, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 6, 2024 •
edited
Loading

Description

  • Support for defaultProps will be removed from function components in a future major release.
  • Use JavaScript default parameters instead.

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested review from pavelklibani and a team as code owners February 6, 2024 15:34
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 35a0b1f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65c25190932b550008fb6ed8

@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 35a0b1f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65c251907cde9f0008c0818d
😎 Deploy Preview https://deploy-preview-1267--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Feb 6, 2024
@literat literat marked this pull request as draft February 6, 2024 15:35
@literat literat force-pushed the fix/DS-1145-web-react-icon-html-parser branch from 3258fb6 to 2d1a815 Compare February 7, 2024 14:41
Base automatically changed from fix/DS-1145-web-react-icon-html-parser to main February 7, 2024 15:04
@literat literat mentioned this pull request Apr 3, 2024
Merged
@crishpeen crishpeen force-pushed the refactor/web-react-deprecate-default-props branch from 35a0b1f to 7cf7f6d Compare April 9, 2024 14:52
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit ac4cd95
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/661ed6141e89ce0009385e47
😎 Deploy Preview https://deploy-preview-1267--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ac4cd95
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/661ed6147dd5bc0008b20571
😎 Deploy Preview https://deploy-preview-1267--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit ac4cd95
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/661ed61488c76200083fe3cd

@coveralls
Copy link

coveralls commented Apr 9, 2024 •
edited
Loading

Coverage Status

coverage: 80.873% (-15.5%) from 96.371%
when pulling ac4cd95 on refactor/web-react-deprecate-default-props
into 0ca4ef1 on main.

@literat literat marked this pull request as ready for review April 9, 2024 20:01
@literat literat force-pushed the refactor/web-react-deprecate-default-props branch from 3e38df8 to 9b2aef8 Compare April 11, 2024 18:47
@literat
Refactor(web-react): Move away from the defaultProps
ac4cd95 
  * Support for defaultProps will be removed from function components in a future major release.
  * Use JavaScript default parameters instead.
@literat literat force-pushed the refactor/web-react-deprecate-default-props branch from 9b2aef8 to ac4cd95 Compare April 16, 2024 19:48
@literat literat merged commit d70e5ff into main Apr 16, 2024
21 checks passed
@literat literat deleted the refactor/web-react-deprecate-default-props branch April 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@literat literat

Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@literat @coveralls @crishpeen