Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Introduce option to disable scrolling inside Modal #… #1263

Merged

Conversation

crishpeen
Copy link
Member

…DS-732

Scrolling inside ModalDialog can now be turned off by setting the isScrollable prop to false.

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen requested a review from adamkudrna February 5, 2024 19:33
@crishpeen crishpeen requested review from literat, pavelklibani and a team as code owners February 5, 2024 19:33
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 4bddca4
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65c2223b2e8536000816f997

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 4bddca4
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65c2223bd6490800092a519e
😎 Deploy Preview https://deploy-preview-1263--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Feb 5, 2024
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things that need to be done. Otherwise, it is looking good.

@crishpeen crishpeen force-pushed the feature/web-react-modal-scrolling branch from b001ee1 to ed37404 Compare February 6, 2024 12:06
…DS-732

Scrolling inside `ModalDialog` can now be turned off by setting the `isScrollable` prop to false.
@crishpeen crishpeen force-pushed the feature/web-react-modal-scrolling branch from ed37404 to 4bddca4 Compare February 6, 2024 12:12
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Coverage Status

coverage: 72.818% (-8.2%) from 80.979%
when pulling 4bddca4 on feature/web-react-modal-scrolling
into 31f9964 on feature/web-modal-scrolling.

@crishpeen crishpeen merged commit 8491e38 into feature/web-modal-scrolling Feb 6, 2024
15 checks passed
@crishpeen crishpeen deleted the feature/web-react-modal-scrolling branch February 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants