-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web-react): Introduce option to disable scrolling inside Modal #… #1263
Merged
crishpeen
merged 1 commit into
feature/web-modal-scrolling
from
feature/web-react-modal-scrolling
Feb 6, 2024
Merged
Feat(web-react): Introduce option to disable scrolling inside Modal #… #1263
crishpeen
merged 1 commit into
feature/web-modal-scrolling
from
feature/web-react-modal-scrolling
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
pavelklibani and
a team
as code owners
February 5, 2024 19:33
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pavelklibani
approved these changes
Feb 6, 2024
literat
reviewed
Feb 6, 2024
literat
reviewed
Feb 6, 2024
literat
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things that need to be done. Otherwise, it is looking good.
crishpeen
force-pushed
the
feature/web-react-modal-scrolling
branch
from
February 6, 2024 12:06
b001ee1
to
ed37404
Compare
…DS-732 Scrolling inside `ModalDialog` can now be turned off by setting the `isScrollable` prop to false.
crishpeen
force-pushed
the
feature/web-react-modal-scrolling
branch
from
February 6, 2024 12:12
ed37404
to
4bddca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DS-732
Scrolling inside
ModalDialog
can now be turned off by setting theisScrollable
prop to false.Description
Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123
).