Fix(web, web-twig, web-react): Tooltip on Icon component #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Icon component now accept forwarded ref and can be used as TooltipTrigger
- elementType can be now self closing (fe. Icon) - accepting props from elementType components
- New demo with tooltip on Icon component
- New demo with tooltip on Icon component
- New demo with tooltip on Icon element
pavelklibani
force-pushed
the
tooltip-on-icons
branch
from
0fe154f to
48da1b2
Compare
|
Thanks for these changes! 🙏🏻 Could you also update documentation? We're little bit missing mention about |
literat
reviewed
Feb 6, 2024
| Close me | ||
| </TooltipPopov> | ||
| </TooltipWrapper> | ||
| </span> |
pavelklibani
changed the base branch from
main
to
feat/DS-1140-tooltip-hover
pavelklibani
force-pushed
the
feat/DS-1140-tooltip-hover
branch
from
4897164 to
9f1589f
Compare
|
moved to #1268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added forwardedRef to our
<Icon />component so it can be used aselementTypefor<TooltipTrigger>component.Added new demo for tooltip on Icon components for all packages
Additional context
Requested in our support channel:
https://almamedia.slack.com/archives/C068XPSDWQN/p1706807163184249