Integration/tooltip #1257
Merged
Integration/tooltip #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
a team,
adamkudrna and
crishpeen
as code owners
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo canceled.
|
|
I have confirmation from @dlouhak that the web package is working fine (both installation and usage). |
crishpeen
reviewed
Jan 30, 2024
crishpeen
reviewed
Jan 30, 2024
crishpeen
reviewed
Jan 30, 2024
crishpeen
reviewed
Jan 30, 2024
packages/web-react/src/components/TooltipModern/demo/TooltipWithFloatingUI.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/TooltipModern/demo/TooltipWithFloatingUI.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/TooltipModern/demo/TooltipPlacements.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/TooltipModern/demo/TooltipOnHover.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tooltip/__tests__/useTooltipModernStyleProps.test.ts
Outdated
Show resolved
Hide resolved
adamkudrna
reviewed
Jan 30, 2024
There was a problem hiding this comment.
It wouldn't be me if I didn't find a few things. But, hats off to @pavelklibani for the incredible job! 👏🏻
packages/web-twig/src/Resources/components/Tooltip/Tooltip.twig
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/TooltipModern/stories/TooltipModern.stories.tsx
Show resolved
Hide resolved
crishpeen
approved these changes
Jan 30, 2024
packages/web-react/src/components/TooltipModern/demo/TooltipPlacements.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/TooltipModern/demo/TooltipPlacements.tsx
Outdated
Show resolved
Hide resolved
- added new variable --tooltip-max-width - changed from 18rem to 288px
- Tooltip addon changes - Tooltip example demo changes - Tooltip readme changes - Delete old floating ui example
* advanced floating functionality was applied on all tooltips with
data-spirit-toggle="tooltip"
pavelklibani
force-pushed
the
integration/tooltip
branch
from
3d6207c to
1f6677b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123).