Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(ci): Rename label that runs visual tests on PR #1244

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Jan 19, 2024

Description

We have agreed that we will be using the label run visual tests for PRs where we want to run visual tests.

The label e2e is removed.

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested a review from a team as a code owner January 19, 2024 17:12
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 7ab3f2e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65aaad727136eb0009f82512

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Jan 19, 2024
@literat literat requested a review from pavelklibani January 19, 2024 17:12
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 7ab3f2e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65aaad722fdb4b0008c1b792

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 7ab3f2e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65aaad72a3d8d3000831b7f9

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 7ab3f2e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65aaad72b159f400087ec941

Copy link
Contributor

Coverage Status

coverage: 71.623% (-24.9%) from 96.491%
when pulling 7ab3f2e on chore/ci-run-visual-tests
into d1da586 on main.

.github/workflows/e2e.yml Show resolved Hide resolved
@literat literat merged commit 8befaa8 into main Jan 23, 2024
21 checks passed
@literat literat deleted the chore/ci-run-visual-tests branch January 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants