Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): FloatingUI integration to TooltipModern #DS-1088 #1237

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Feat(web-react): FloatingUI integration to TooltipModern #DS-1088 #1237

merged 4 commits into from
Jan 25, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Jan 17, 2024 •
edited
Loading

Description

Introducing new component <TooltipModern> and it's sub components <TooltipTrigger> and <TooltipPopover>

Issue reference

#DS-1088 Web-react: Integrovat Floating UI přímo do Tooltipu

@pavelklibani pavelklibani self-assigned this Jan 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 0990447
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65b107b8317e0f00080a6a6b
😎 Deploy Preview https://deploy-preview-1237--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Jan 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit fa89440
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65b10954820a2b0008e0c63a

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 0990447
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65b107b8e9bc950008c795f7

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit fa89440
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65b10954116a4e0008ed77e0
😎 Deploy Preview https://deploy-preview-1237--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Status

coverage: 70.934% (-25.6%) from 96.491%
when pulling cf6bbc7 on feat/DS-1088-fui-integration-react
into 70d6746 on main.

@coveralls
Copy link

coveralls commented Jan 18, 2024 •
edited
Loading

Coverage Status

coverage: 80.808% (-15.6%) from 96.371%
when pulling fa89440 on feat/DS-1088-fui-integration-react
into bba9fb3 on integration/tooltip.

@literat
Copy link
Collaborator

literat commented Jan 19, 2024

Great Job 👏 Please add some unit tests and it will be great 👍 :-)

@pavelklibani pavelklibani marked this pull request as ready for review January 22, 2024 09:58
@pavelklibani pavelklibani requested review from a team, adamkudrna and crishpeen as code owners January 22, 2024 09:58
adamkudrna
adamkudrna reviewed Jan 22, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/DS-1088-fui-integration-react branch from 3ffba01 to 93236de Compare January 22, 2024 17:41
@pavelklibani pavelklibani changed the title Feat/ds 1088 fui integration react Feat(web-react): FloatingUI integration to TooltipModern #DS-1088 Jan 22, 2024
literat
literat approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 I have now finding only some unimportant details so for me this is finished :-)

@literat literat mentioned this pull request Jan 23, 2024
Closed
@pavelklibani pavelklibani force-pushed the feat/DS-1088-fui-integration-react branch from 93236de to 0990447 Compare January 24, 2024 12:51
@pavelklibani pavelklibani changed the base branch from main to integration/tooltip January 24, 2024 12:51
@pavelklibani pavelklibani force-pushed the feat/DS-1088-fui-integration-react branch from 0990447 to fa89440 Compare January 24, 2024 12:57
@pavelklibani pavelklibani merged commit fe90dfc into integration/tooltip Jan 25, 2024
21 checks passed
@pavelklibani pavelklibani deleted the feat/DS-1088-fui-integration-react branch January 25, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat approved these changes

@crishpeen crishpeen Awaiting requested review from crishpeen

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @adamkudrna