Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web): Simplify scroll-control to only block overflow and not set … #1230

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

crishpeen
Copy link
Member

…position fixed

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 0c7a00b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/659fbe89f29dc20008968e79
😎 Deploy Preview https://deploy-preview-1230--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 0c7a00b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/659fbe89daccd9000899997b

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 0c7a00b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/659fbe89d655a20008e08f1d
😎 Deploy Preview https://deploy-preview-1230--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 0c7a00b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/659fbe895c891200084c7f10
😎 Deploy Preview https://deploy-preview-1230--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 9, 2024

Coverage Status

coverage: 79.975% (+3.8%) from 76.222%
when pulling 0c7a00b on fix/simplify-scroll-control
into bfa569f on main.

@crishpeen crishpeen force-pushed the fix/simplify-scroll-control branch from d5f4db2 to 7ec7acd Compare January 9, 2024 15:54
@crishpeen crishpeen marked this pull request as ready for review January 9, 2024 15:54
@dlouhak
Copy link
Contributor

dlouhak commented Jan 11, 2024

❤️

@adamkudrna
Copy link
Contributor

I'd change the commit messages:

Simplify scroll-control to only block overflow and not set position fixed

to:

Simplify scroll blocking used by `Modal` to CSS-only solution

Or something even less complicated 🙂

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 And @dlouhak wrote that it is also working for her.

@crishpeen crishpeen force-pushed the fix/simplify-scroll-control branch from 7ec7acd to 0c7a00b Compare January 11, 2024 10:10
@crishpeen crishpeen merged commit 0df3c47 into main Jan 11, 2024
22 checks passed
@crishpeen crishpeen deleted the fix/simplify-scroll-control branch January 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants