Fix(web-react): Closing Modal by Escape key #1206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `cancel` event was not fired while closing dialog using escape key
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pavelklibani
reviewed
Jan 8, 2024
| * Here should be used `cancel` event instead of `close` event. | ||
| * But when dialog is closed using `escape` key, `cancel` event is not fired. | ||
| */ | ||
| const EVENT_CANCEL = 'close'; |
There was a problem hiding this comment.
I was looking at this option to change cancel for close, but now if you close modal with close button on with backdrop click onClose method is called twice - from button/backdrop and from close event. Are we ok with that?
|
Close as fixed elsewhere? |
|
This was fixed in a newer version of Chrome (between 216 and 234). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cancelevent was not fired while closing dialog using escape keyAdditional context
Issue reference
https://jira.lmc.cz/browse/DS-1108
Before submitting the PR, please make sure you do the following
fixes #123).