Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(web): Require sass from v1.57.0 above due to string.split #1205

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Jan 5, 2024

Description

string.split is in Sass since 1.57.0

Additional context

https://sass-lang.com/documentation/modules/string/#split

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5619e36
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6597f6c1414d5b00089c7a03

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Jan 5, 2024
Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 5619e36
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6597f6c1ed195e0008e648d0

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 5619e36
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6597f6c144bdcf0008208d43

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 5619e36
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6597f6c1adc66100081032af

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Coverage Status

coverage: 70.462% (-9.2%) from 79.697%
when pulling 5619e36 on chore/wrong-sass-version
into cbe878b on main.

@literat literat merged commit cf65e20 into main Jan 8, 2024
23 checks passed
@literat literat deleted the chore/wrong-sass-version branch January 8, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants