Fix Lerna build of all packages #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* and update it in dev dependecies
* this will work when running `yarn lerna run build --scope
@lmc-eu/spirit-design-tokens`
* lerna should determine paralelization based on dependencies or
devDependencies, but this do not work 🤷
* we can use `yarn lerna run build --concurrency 1` to disable this
but it is slow and takes a long time
* `design-tokens` must be build first so I have splitted up the `web*`
packages to be build after the rest of the packages
* problem can be test by simply running `yarn lerna run build
--scope=@lmc-eu/spirit-design-tokens
--scope=@lmc-eu/spirit-web-react`
literat
requested review from
pavelklibani,
a team,
adamkudrna and
crishpeen
as code owners
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
github-actions
bot
added
the
maintenance
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
pavelklibani
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
devDependencies, but this do not work 🤷
yarn lerna run build --concurrency 1to disable thisbut it is slow and takes a long time
design-tokensmust be build first so I have splitted up theweb*packages to be build after the rest of the packages
yarn lerna run build --scope=@lmc-eu/spirit-design-tokens --scope=@lmc-eu/spirit-web-reactAdditional context
https://stackoverflow.com/questions/67154137/how-to-run-lerna-sequentially
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123).