Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSR of Icon component #1200

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Fix SSR of Icon component #1200

merged 4 commits into from
Jan 10, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Jan 3, 2024

Description

Another try to fix the loading of Icon while using SSR on Next.js.

Additional context

Testing build: lmc-eu-spirit-web-react-v1.8.1-alpha.3.tgz

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 696ab8b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/659e7325551c80000835318f
😎 Deploy Preview https://deploy-preview-1200--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Jan 3, 2024
@literat literat requested a review from janicekt January 3, 2024 12:59
Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 696ab8b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/659e7325083747000819390e

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 696ab8b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/659e732545affa00082d56e2

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 696ab8b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/659e73259be927000814b219
😎 Deploy Preview https://deploy-preview-1200--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 79.734% (+2.5%) from 77.257%
when pulling d49062e on fix/DS-1110-ssr-icons
into 6e068c9 on main.

@literat literat marked this pull request as ready for review January 3, 2024 20:31
@literat literat requested review from pavelklibani and a team as code owners January 3, 2024 20:31
@literat literat force-pushed the fix/DS-1110-ssr-icons branch from d49062e to 696ab8b Compare January 10, 2024 10:36
@literat literat merged commit fd456b4 into main Jan 10, 2024
28 checks passed
@literat literat deleted the fix/DS-1110-ssr-icons branch January 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants