Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): FloatingUI integration to Tooltip #DS-1086 #1197

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Feat(web): FloatingUI integration to Tooltip #DS-1086 #1197

merged 3 commits into from
Jan 25, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pavelklibani pavelklibani self-assigned this Jan 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 82e34ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/659e916711bcff000891325c
😎 Deploy Preview https://deploy-preview-1197--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Jan 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit e69f597
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65b234670e483b00089f23ca
😎 Deploy Preview https://deploy-preview-1197--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 82e34ec
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/659e9167f63444000803f9c4

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit e69f597
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65b23467cd8bd40008a9f172
😎 Deploy Preview https://deploy-preview-1197--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Coverage Status

coverage: 72.111% (-5.1%) from 77.257%
when pulling d027620 on feat/DS-1086-fui-integration
into 6e068c9 on main.

@literat
Copy link
Collaborator

literat commented Jan 3, 2024

Nice work! So many calculations :-) But it is looking good and it works fine. We should finalize this tomorrow :-)

@pavelklibani pavelklibani marked this pull request as ready for review January 4, 2024 06:55
@pavelklibani pavelklibani requested review from adamkudrna, crishpeen and a team as code owners January 4, 2024 06:55
@pavelklibani pavelklibani force-pushed the feat/DS-1086-fui-integration branch from 331fb7e to 1c2a531 Compare January 8, 2024 13:48
@coveralls
Copy link

coveralls commented Jan 8, 2024 •
edited by github-actions bot
Loading

Coverage Status

Changes unknown
when pulling e69f597 on feat/DS-1086-fui-integration
into ** on integration/tooltip**.

literat
literat approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Good Job! Thanks a lot I know it was exhausting :-)

adamkudrna
adamkudrna reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! 👏🏻

packages/web/src/js/Tooltip.ts Show resolved Hide resolved
packages/web/package.json Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/index.html Show resolved Hide resolved
@adamkudrna adamkudrna mentioned this pull request Jan 9, 2024
Merged
@pavelklibani pavelklibani force-pushed the feat/DS-1086-fui-integration branch from 3a32272 to 82e34ec Compare January 10, 2024 12:45
@pavelklibani pavelklibani changed the base branch from main to integration/tooltip January 10, 2024 12:47
literat
literat reviewed Jan 22, 2024
View reviewed changes
packages/web/package.json
@@ -88,6 +88,7 @@
"vite-plugin-handlebars": "1.6.0"
},
"peerDependencies": {
"@floating-ui/dom": "^1.5.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add this also to dev dependencies.

literat
literat reviewed Jan 22, 2024
View reviewed changes
packages/web/src/scss/components/Tooltip/index.html

<div class="docs-Stack docs-Stack--start spirit-feature-tooltip-enable-data-placement">

<h3>Without Floating UI</h3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is without Floating UI, because the plugin is used...

@literat literat mentioned this pull request Jan 23, 2024
Closed
@pavelklibani pavelklibani force-pushed the feat/DS-1086-fui-integration branch from f5f004f to e69f597 Compare January 25, 2024 10:13
@pavelklibani pavelklibani merged commit ece47b5 into integration/tooltip Jan 25, 2024
21 checks passed
@pavelklibani pavelklibani deleted the feat/DS-1086-fui-integration branch January 25, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat approved these changes

@crishpeen crishpeen Awaiting requested review from crishpeen

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @literat @coveralls @adamkudrna