Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Introduce spacing style props to all components #DS-475 #1194

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Feat(web-react): Introduce spacing style props to all components #DS-475 #1194

merged 2 commits into from
Jan 23, 2024

Conversation

crishpeen
Copy link
Member

@crishpeen crishpeen commented Dec 29, 2023 •
edited
Loading

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen self-assigned this Dec 29, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 4d59a0b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65af9cdd3600870007186448
😎 Deploy Preview https://deploy-preview-1194--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 4d59a0b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65af9cdd256bd1000868f283
😎 Deploy Preview https://deploy-preview-1194--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Dec 29, 2023
@crishpeen crishpeen force-pushed the feature/custom-stack-spacing branch 2 times, most recently from 8fb5f23 to ae95c35 Compare January 2, 2024 15:51
@crishpeen crishpeen force-pushed the feature/custom-stack-spacing branch 2 times, most recently from 8a3f53d to 07b91de Compare January 4, 2024 15:15
Base automatically changed from feature/custom-stack-spacing to main January 4, 2024 15:22
@crishpeen crishpeen force-pushed the feature/react-style-props-spacing branch from 8b4bd9d to f2c5d42 Compare January 4, 2024 15:26
@crishpeen crishpeen marked this pull request as ready for review January 4, 2024 15:26
@crishpeen crishpeen requested review from pavelklibani and a team as code owners January 4, 2024 15:26
@coveralls
Copy link

coveralls commented Jan 4, 2024 •
edited
Loading

Coverage Status

coverage: 80.57% (+0.2%) from 80.368%
when pulling 4d59a0b on feature/react-style-props-spacing
into 654a147 on main.

@netlify Netlify
Copy link

netlify bot commented Jan 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 4d59a0b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65af9cdd7a7a6e00089314a3
😎 Deploy Preview https://deploy-preview-1194--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 4, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4d59a0b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65af9cddb4025f0008311adf

literat
literat approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good. Just few tweaks ;-)

@crishpeen crishpeen force-pushed the feature/react-style-props-spacing branch from f2c5d42 to b77243c Compare January 16, 2024 10:08
@crishpeen crishpeen requested a review from adamkudrna January 16, 2024 10:08
@crishpeen crishpeen force-pushed the feature/react-style-props-spacing branch from b77243c to e54c463 Compare January 18, 2024 12:07
literat
literat approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just a few tweaks and maybe you can add the test to the test provider as we speak about it personally.

adamkudrna
adamkudrna reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, a ✅ for me. I only wish if we could bring the Twig and React tests even closer so we can be sure the style props do the same thing in both technologies.

packages/web-react/src/hooks/__tests__/useStyleUtilities.test.ts Show resolved Hide resolved
packages/web-react/src/hooks/useStyleUtilities.ts Outdated Show resolved Hide resolved
packages/web-react/src/types/shared/style.ts Outdated Show resolved Hide resolved
packages/web-react/src/hooks/useStyleUtilities.ts Show resolved Hide resolved
packages/web-react/src/hooks/useStyleUtilities.ts Show resolved Hide resolved
packages/web-react/src/hooks/useStyleUtilities.ts Show resolved Hide resolved
packages/web-react/src/types/shared/tokens.ts Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feature/react-style-props-spacing branch from 1f7f5d8 to 4d59a0b Compare January 23, 2024 11:02
@literat literat mentioned this pull request Jan 23, 2024
Open
@crishpeen crishpeen merged commit b6b8721 into main Jan 23, 2024
28 checks passed
@crishpeen crishpeen deleted the feature/react-style-props-spacing branch January 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @coveralls @literat @adamkudrna