Introduce optional uniform appearance of Modal #DS-1091
#1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
crishpeen
reviewed
Dec 21, 2023
pavelklibani
approved these changes
Dec 21, 2023
adamkudrna
force-pushed
the
feature/web-modal-uniform-design-on-all-breakpoints
branch
from
b6d9429 to
a8b3577
Compare
literat
approved these changes
Jan 3, 2024
adamkudrna
force-pushed
the
feature/web-modal-uniform-design-on-all-breakpoints
branch
from
a8b3577 to
51ef849
Compare
Add `spirit-feature-modal-enable-uniform-dialog` feature class to enable uniform appearance of `Modal` across all breakpoints. Current mobile design is then accessible using the `Modal--dockOnMobile` modifier class.
…nsumption Firefox warns about potential high memory consumption when `will-change` is used on big areas. Therefore it seems better to remove it in this case to free up the memory for smaller tweaks in Spirit and also for other performance optimisations our users might want to make. https://dev.opera.com/articles/css-will-change-property/
…te values in `Modal` docs
adamkudrna
force-pushed
the
feature/web-modal-uniform-design-on-all-breakpoints
branch
from
51ef849 to
b4fccc4
Compare
adamkudrna
deleted the
feature/web-modal-uniform-design-on-all-breakpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
spirit-feature-modal-enable-uniform-dialogfeature class to enable uniform appearance ofModalacross all breakpoints.Current mobile design is then accessible using the
Modal--dockOnMobilemodifier class.Additional context
We need to make sure it works in all scenarios:
Issue reference
https://jira.lmc.cz/browse/DS-1091