Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(analytics): HTML element is not the PascalCase component #1182

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 11, 2023

Description

Double-check the component name and assert it for PascalCase, because HTML elements are not PascalCase written.

In our adoption data, we have some components marked as html_element.

  "html_element:ProgressBar": [
    {
      "path": "templates/front/macros/rating.html.twig:221",
      "props": {
        "size": "small",
        "value": "{{ percentage }}"
      }
    }
  ],

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested a review from a team as a code owner December 11, 2023 13:52
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit e53bb4e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/657714088d4e6400087e13d7

@github-actions github-actions bot added the bug Something isn't working label Dec 11, 2023
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit e53bb4e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6577140812b4590008f9d007

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit e53bb4e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65771408e3a440000846d78b

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit e53bb4e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/657714081c60ad00086f660f

Copy link
Contributor

Coverage Status

coverage: 70.462% (-9.2%) from 79.617%
when pulling e53bb4e on fix/analytics-twig-local-components
into 02c3ddf on main.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@literat literat merged commit 4ddf584 into main Dec 12, 2023
22 checks passed
@literat literat deleted the fix/analytics-twig-local-components branch December 12, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants