Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Do not render empty style prop #1179

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 8, 2023

Description

When not using UNSAFE_style prop, the default {} is rendered into the DOM. Using undefined instead.

Additional context

Every snapshot in product, like KukAD:

<ul
        className="Tabs"
        role="tablist"
        style={{}} // <- here
>

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested review from pavelklibani and a team as code owners December 8, 2023 12:49
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 4121e2f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6573323fa3b6fe000875817d

@github-actions github-actions bot added the bug Something isn't working label Dec 8, 2023
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 4121e2f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6573323fd6a7c50008d6d455

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4121e2f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6573323f6a308c0008364783

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 4121e2f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6573323fd9d9a00008c3e92a

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Coverage Status

coverage: 70.462% (-9.2%) from 79.617%
when pulling 4121e2f on fix/web-react-do-not-render-empty-style
into 02c3ddf on main.

@literat literat force-pushed the fix/web-react-do-not-render-empty-style branch from 7758939 to 4121e2f Compare December 8, 2023 15:11
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Coverage Status

coverage: 70.462% (-9.2%) from 79.617%
when pulling 4121e2f on fix/web-react-do-not-render-empty-style
into 02c3ddf on main.

@literat literat merged commit 5bd5dfa into main Jan 10, 2024
29 checks passed
@literat literat deleted the fix/web-react-do-not-render-empty-style branch January 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant