Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-twig): Introduce Full Floating UI demo to Tooltip, update internal implementation #DS-1084 #1178

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

crishpeen
Copy link
Member

Switch to data attribute placement instead of modification class based.

Description

Additional context

Issue reference

DS-1084


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 6e6b87f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65783316672eed000857e312

@github-actions github-actions bot added the feature New feature or request label Dec 7, 2023
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 6e6b87f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65783316124c15000833213c

@coveralls
Copy link

coveralls commented Dec 7, 2023

Coverage Status

coverage: 70.462% (-9.2%) from 79.617%
when pulling 6e6b87f on feat/twig-tooltip-floating-demo
into 02c3ddf on main.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 6e6b87f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/657833169560920008510c12

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 6e6b87f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6578331699e45a000842662c

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing: is there a chance to improve the README according to the web package? I'm sure our users will appreciate if there are instructions for placement, interaction etc. 🙏🏻

@crishpeen
Copy link
Member Author

Just one thing: is there a chance to improve the README according to the web package? I'm sure our users will appreciate if there are instructions for placement, interaction etc. 🙏🏻

TBH I don't want to do this now. as this PR is mainly to match demos.

We are already working on including the floating UI directly in the Tooltip and part of it should be an overhaul of the Docs. I don't see the added value to refactoring docs now.

…ternal implementation #DS-1084

Switch to data attribute placement instead of modification class based.
@crishpeen crishpeen force-pushed the feat/twig-tooltip-floating-demo branch from 48a66a8 to 6e6b87f Compare December 12, 2023 10:16
@crishpeen crishpeen merged commit 08822a4 into main Dec 12, 2023
33 checks passed
@crishpeen crishpeen deleted the feat/twig-tooltip-floating-demo branch December 12, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants