-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web-twig): Introduce Full Floating UI demo to Tooltip, update internal implementation #DS-1084 #1178
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
packages/web-twig/src/Resources/components/Tooltip/__tests__/__fixtures__/tooltip.twig
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipPlacements.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing: is there a chance to improve the README
according to the web
package? I'm sure our users will appreciate if there are instructions for placement, interaction etc. 🙏🏻
TBH I don't want to do this now. as this PR is mainly to match demos. We are already working on including the floating UI directly in the Tooltip and part of it should be an overhaul of the Docs. I don't see the added value to refactoring docs now. |
…ternal implementation #DS-1084 Switch to data attribute placement instead of modification class based.
48a66a8
to
6e6b87f
Compare
Switch to data attribute placement instead of modification class based.
Description
Additional context
Issue reference
DS-1084
Before submitting the PR, please make sure you do the following
fixes #123
).