Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Mock window.scrollTo in test of useScrollControl hook #1177

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen requested review from literat, pavelklibani and a team as code owners December 7, 2023 15:22
@github-actions github-actions bot added the bug Something isn't working label Dec 7, 2023
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 53980dd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6571e323b867b8000724f870
😎 Deploy Preview https://deploy-preview-1177--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 53980dd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6571e323f6cedf0008c2a3bb
😎 Deploy Preview https://deploy-preview-1177--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 53980dd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6571e3239350bd0008e5f0ad

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Coverage Status

coverage: 70.462% (-9.2%) from 79.617%
when pulling 53980dd on fix/mock-scrollto
into 02c3ddf on main.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 53980dd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6571e3238ddc3b0008ea8c09
😎 Deploy Preview https://deploy-preview-1177--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@crishpeen crishpeen merged commit 343ab51 into main Dec 12, 2023
24 checks passed
@crishpeen crishpeen deleted the fix/mock-scrollto branch December 12, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants