Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Update e2e snapshot of web-react demo homepage #1176

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

crishpeen
Copy link
Member

@crishpeen crishpeen commented Dec 7, 2023

Description

Somehow e2e broke and we didn't realize that until it was in the main branch. I suspect that when we added only one item to the HP it didn't break because the threshold of maxDiffPixelRatio is set to 0.01.

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen requested a review from a team as a code owner December 7, 2023 09:10
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 896c65a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/657195453362ff00082a1b36

@github-actions github-actions bot added the bug Something isn't working label Dec 7, 2023
@literat
Copy link
Collaborator

literat commented Dec 7, 2023

Typo in commit or -> of.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 896c65a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6571954570d3a70008dee2b9

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 896c65a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6571954551771d000804b0d4

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 896c65a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65719545ea857400088a9dd6

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Coverage Status

coverage: 70.462% (-26.0%) from 96.46%
when pulling f43f531 on fix/e2e-react-hp-update
into 734c46e on main.

@crishpeen crishpeen force-pushed the fix/e2e-react-hp-update branch from f43f531 to 896c65a Compare December 7, 2023 09:49
@crishpeen crishpeen changed the title Fix(web-react): Update e2e snapshot or web-react demo homepage Fix(web-react): Update e2e snapshot of web-react demo homepage Dec 7, 2023
@coveralls
Copy link

coveralls commented Dec 7, 2023

Coverage Status

coverage: 79.617% (-16.8%) from 96.46%
when pulling 896c65a on fix/e2e-react-hp-update
into 734c46e on main.

@crishpeen crishpeen merged commit 72a8fc8 into main Dec 7, 2023
21 checks passed
@crishpeen crishpeen deleted the fix/e2e-react-hp-update branch December 7, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants