Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Introduce custom Stack spacing #DS-1079 #1175

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

DS-1079


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 07b91de
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6596cb78ed4a1f0008bfbb94

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 07b91de
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6596cb78b89061000839d180

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 07b91de
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6596cb78b8861f0008ba4d44
😎 Deploy Preview https://deploy-preview-1175--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Dec 5, 2023
@crishpeen crishpeen marked this pull request as draft December 5, 2023 15:40
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 07b91de
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6596cb78d4e619000881db86
😎 Deploy Preview https://deploy-preview-1175--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen
Copy link
Member Author

Converted to draft, till we finish everything in the current sprint as this is not a priority now.

@coveralls
Copy link

coveralls commented Dec 5, 2023

Coverage Status

coverage: 79.697% (+0.07%) from 79.629%
when pulling 07b91de on feature/custom-stack-spacing
into c205a10 on main.

@crishpeen crishpeen marked this pull request as ready for review December 12, 2023 12:56
@crishpeen crishpeen force-pushed the feature/custom-stack-spacing branch from b9ca594 to 044843a Compare December 14, 2023 10:12
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/web/src/scss/foundation/_tokens.scss Show resolved Hide resolved
packages/web/src/scss/components/Stack/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/_Stack.scss Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feature/custom-stack-spacing branch 2 times, most recently from 8fb5f23 to ae95c35 Compare January 2, 2024 15:51
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

packages/web/src/scss/components/Stack/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/_Stack.scss Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feature/custom-stack-spacing branch from ae95c35 to 8a3f53d Compare January 4, 2024 12:29
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@crishpeen crishpeen force-pushed the feature/custom-stack-spacing branch from 8a3f53d to 07b91de Compare January 4, 2024 15:15
@crishpeen crishpeen merged commit 3a6f9f0 into main Jan 4, 2024
34 checks passed
@crishpeen crishpeen deleted the feature/custom-stack-spacing branch January 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants