Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web, web-react, web-twig): Item in Dropdown demos #DS-956 #1174

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Docs(web, web-react, web-twig): Item in Dropdown demos #DS-956 #1174

merged 5 commits into from
Dec 12, 2023

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference

Použití Item komponenty v Dropdownu

@pavelklibani pavelklibani self-assigned this Dec 4, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 1eb511d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65784f01d2912c0008504bb9

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 4, 2023
@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Coverage Status

coverage: 79.194% (-17.3%) from 96.491%
when pulling 1eb511d on docs/DS-956-item-dropdown-demos
into b8a89f9 on main.

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 1eb511d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65784f0158f38a00083b6319

@pavelklibani pavelklibani force-pushed the docs/DS-956-item-dropdown-demos branch from 3a6e19e to c23a763 Compare December 4, 2023 22:46
@pavelklibani pavelklibani changed the title Docs/ds 956 item dropdown demos Docs(web, web-react, web-twig): Item in dropdown demos #DS-956 Dec 4, 2023
@pavelklibani pavelklibani changed the title Docs(web, web-react, web-twig): Item in dropdown demos #DS-956 Docs(web, web-react, web-twig): Item in Dropdown demos #DS-956 Dec 4, 2023
@pavelklibani pavelklibani marked this pull request as ready for review December 4, 2023 22:47
Base automatically changed from integration/item to main December 5, 2023 15:13
@pavelklibani pavelklibani force-pushed the docs/DS-956-item-dropdown-demos branch from dcb90ab to 9b859e5 Compare December 5, 2023 15:16
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 1eb511d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65784f0194820c0008b4b2e2

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 1eb511d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65784f01f4d4590008665798

adamkudrna
adamkudrna approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

packages/web/src/scss/components/Dropdown/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Dropdown/stories/DropdownFeatureEnhancedShadow.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Item/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Dropdown/README.md Show resolved Hide resolved
literat
literat approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not forget to update the end-to-end tests.

@pavelklibani pavelklibani force-pushed the docs/DS-956-item-dropdown-demos branch 3 times, most recently from faa1ddb to a405595 Compare December 12, 2023 08:38
@literat
Copy link
Collaborator

literat commented Dec 12, 2023

The problem with the PHP has been fixed in #1183

@pavelklibani pavelklibani force-pushed the docs/DS-956-item-dropdown-demos branch from a405595 to 1eb511d Compare December 12, 2023 12:15
@pavelklibani pavelklibani merged commit 82df19a into main Dec 12, 2023
35 checks passed
@pavelklibani pavelklibani deleted the docs/DS-956-item-dropdown-demos branch December 12, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen is a code owner

Assignees

@pavelklibani pavelklibani

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelklibani @coveralls @literat @adamkudrna @crishpeen