Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fileuploader multiple meta #1173

Closed
wants to merge 2 commits into from
Closed

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 1, 2023

Description

Not quite sure about this solution yet.

Additional context

Issue reference

https://almamedia.slack.com/archives/C050YPZ3YRW/p1701428272055529


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested review from pavelklibani and a team as code owners December 1, 2023 13:38
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 6a51025
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6569e1c825b5ec00084c6714

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 6a51025
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6569e1c855ab140008c15ac8
😎 Deploy Preview https://deploy-preview-1173--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Dec 1, 2023
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 6a51025
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6569e1c806a4ea00080a2559
😎 Deploy Preview https://deploy-preview-1173--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 6a51025
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6569e1c8df3a140008ad50ac

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Coverage Status

coverage: 70.462% (-9.0%) from 79.479%
when pulling 6a51025 on fix/fileuploader-multiple-meta
into 5bf52c1 on main.

@coveralls
Copy link

Coverage Status

coverage: 79.479%. remained the same
when pulling 6a51025 on fix/fileuploader-multiple-meta
into 5bf52c1 on main.

@pavelklibani
Copy link
Contributor

Shouldn't this be done also in web?
packages/web/src/scss/components/FileUploader/index.html

@literat
Copy link
Collaborator Author

literat commented Dec 5, 2023

This is not needed. I was solved a different way. See the Slack.

@literat literat closed this Dec 5, 2023
@literat literat deleted the fix/fileuploader-multiple-meta branch December 5, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants