Fix(web-react): HeaderDialog demo missed closeOnBackdropClick prop #DS-1075 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
crishpeen
reviewed
Nov 30, 2023
packages/web-react/src/components/Header/demo/HeaderInvertedWithActions.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Header/demo/HeaderInvertedWithActionsAndDialog.tsx
Outdated
Show resolved
Hide resolved
crishpeen
reviewed
Nov 30, 2023
There was a problem hiding this comment.
and it doesn't work for me :( https://deploy-preview-1169--spirit-design-system-react.netlify.app/src/components/header/
pavelklibani
force-pushed
the
fix/DS-1075-headerdialog-clickoutside
branch
from
bbd969f to
a9f7a23
Compare
- Dialog component now have default value `true` on closeOnBackdropClick solve #DS-1075
pavelklibani
force-pushed
the
fix/DS-1075-headerdialog-clickoutside
branch
from
21e231d to
0361182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closeOnBackdropClickto true on<Dialog />component.closeOnBackdropClickfrom<Modal />(will be default from Dialog)Additional context
Issue reference
HeaderDialog v React se nezavírá při backdrop click