Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): TabLink, HeaderLink and HeaderDialogLink now accept a NextLink #DS-1018 #DS-1003 #1168

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix(web-react): TabLink, HeaderLink and HeaderDialogLink now accept a NextLink #DS-1018 #DS-1003 #1168

merged 2 commits into from
Dec 1, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 29, 2023 •
edited
Loading

Description

DS-1018

  • <TabLink /> and <HeaderLink /> now accept a NextLink and have forwardRef support
  • Added tests for elementTypes

DS-1003

  • <HeaderDialogLink /> now accept a NextLink and have forwardRef support
  • Added tests for elementTypes

Additional context

Issue reference

DS-1018 - TabLink komponenty umí akceptovat NextLink komponentu
DS-1003 - HeaderDialogLink musí podporovat ref forwarding

@pavelklibani
Fix(web-react): Tablink and HeaderLink now accept a NextLink #DS-1018
bc3efbf 
- TabLink and HeaderLink now accept a NextLink and have forwardRef
support
@pavelklibani pavelklibani self-assigned this Nov 29, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit f6a0862
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65699fecfa5cc300085adf6a

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit f6a0862
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65699fec7bed08000846ac5b

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit f6a0862
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65699fecc045a400080d20fb

@github-actions github-actions bot added the bug Something isn't working label Nov 29, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit f6a0862
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65699fec942247000840b8a2

@pavelklibani pavelklibani changed the title Fix(web-react): Tablink and HeaderLink now accept a NextLink #DS-1018 Fix(web-react): TabLink and HeaderLink now accept a NextLink #DS-1018 Nov 29, 2023
@pavelklibani pavelklibani marked this pull request as ready for review November 30, 2023 12:15
@pavelklibani pavelklibani requested review from literat and a team as code owners November 30, 2023 12:15
@pavelklibani pavelklibani force-pushed the fix/DS-1018-tablink-nextlink branch from 7115957 to 3e140e2 Compare November 30, 2023 12:35
@pavelklibani pavelklibani changed the title Fix(web-react): TabLink and HeaderLink now accept a NextLink #DS-1018 Fix(web-react): TabLink and HeaderLink now accept a NextLink #DS-1018 #DS-1003 Nov 30, 2023
@pavelklibani pavelklibani changed the title Fix(web-react): TabLink and HeaderLink now accept a NextLink #DS-1018 #DS-1003 Fix(web-react): TabLink, HeaderLink and HeaderDialogLink now accept a NextLink #DS-1018 #DS-1003 Nov 30, 2023
@coveralls
Copy link

coveralls commented Nov 30, 2023 •
edited
Loading

Coverage Status

coverage: 85.417% (-11.0%) from 96.46%
when pulling c638b92 on fix/DS-1018-tablink-nextlink
into 4adbc16 on main.

literat
literat approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 👍

@pavelklibani pavelklibani force-pushed the fix/DS-1018-tablink-nextlink branch from c638b92 to f6a0862 Compare December 1, 2023 08:57
@pavelklibani pavelklibani merged commit 5bf52c1 into main Dec 1, 2023
7 checks passed
@pavelklibani pavelklibani deleted the fix/DS-1018-tablink-nextlink branch December 1, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

Assignees

@pavelklibani pavelklibani

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelklibani @coveralls @literat