Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-twig): Introduce Item component #DS-1048 #1167

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 27, 2023

Description

Introduce Item component in Twig

Additional context

Issue reference

Web-Twig: Item komponenta

@pavelklibani pavelklibani self-assigned this Nov 27, 2023
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit d91ff7b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6568506a8cd02a000800fa90

@github-actions github-actions bot added the feature New feature or request label Nov 27, 2023
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit d91ff7b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6568506a7f5c560007f050d8
😎 Deploy Preview https://deploy-preview-1167--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 96.46% (+26.0%) from 70.462%
when pulling d91ff7b on feat/DS-1048-twig-item-component
into 7bd2ae7 on integration/item.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we can see in the test, the href attribute doesn't work. We have to fix this.

@pavelklibani pavelklibani force-pushed the feat/DS-1048-twig-item-component branch from dfd600e to e329050 Compare November 28, 2023 09:29
@pavelklibani pavelklibani marked this pull request as ready for review November 28, 2023 09:41
@pavelklibani pavelklibani requested review from literat, adamkudrna and a team as code owners November 28, 2023 09:41
@pavelklibani pavelklibani force-pushed the feat/DS-1048-twig-item-component branch 4 times, most recently from 743afaa to 64ae6dd Compare November 28, 2023 11:32
@pavelklibani pavelklibani changed the title Feat(web-twig): Introduce Item component #DS-1049 Feat(web-twig): Introduce Item component #DS-1048 Nov 28, 2023
@pavelklibani pavelklibani force-pushed the feat/DS-1048-twig-item-component branch from 6643215 to 676a896 Compare November 28, 2023 14:05
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feature/web-item to integration/item November 30, 2023 08:38
@pavelklibani pavelklibani force-pushed the feat/DS-1048-twig-item-component branch 2 times, most recently from 7199a60 to b6ce84f Compare November 30, 2023 08:56
@pavelklibani pavelklibani force-pushed the feat/DS-1048-twig-item-component branch from b6ce84f to d91ff7b Compare November 30, 2023 09:05
@pavelklibani pavelklibani merged commit 84d1e17 into integration/item Nov 30, 2023
24 checks passed
@pavelklibani pavelklibani deleted the feat/DS-1048-twig-item-component branch November 30, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants