-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web-twig): Introduce Item component #DS-1048 #1167
Feat(web-twig): Introduce Item component #DS-1048 #1167
Conversation
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we can see in the test, the href
attribute doesn't work. We have to fix this.
...es/web-twig/src/Resources/components/Item/__tests__/__snapshots__/itemDefault.twig.snap.html
Outdated
Show resolved
Hide resolved
...s/web-twig/src/Resources/components/Item/__tests__/__snapshots__/itemDisabled.twig.snap.html
Outdated
Show resolved
Hide resolved
dfd600e
to
e329050
Compare
743afaa
to
64ae6dd
Compare
6643215
to
676a896
Compare
packages/web-twig/src/Resources/components/Item/__tests__/__fixtures__/itemDisabled.twig
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
packages/web-twig/src/Resources/components/Item/__tests__/__fixtures__/itemDisabled.twig
Show resolved
Hide resolved
7199a60
to
b6ce84f
Compare
b6ce84f
to
d91ff7b
Compare
Description
Introduce Item component in Twig
Additional context
Issue reference
Web-Twig: Item komponenta