Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Introduce Item component #DS-1049 #1163

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 22, 2023

Description

Introducing new Item component in React.

Additional context

Issue reference

Web-React: Item komponenta

@pavelklibani pavelklibani self-assigned this Nov 22, 2023
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6565fd25e747270783feed81
😎 Deploy Preview https://deploy-preview-1163--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Nov 22, 2023
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 3927b7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6568532001a070000813e9fe
😎 Deploy Preview https://deploy-preview-1163--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4330224
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/655f846580b2d90008ffc5bb

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 3927b7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6568532126116c000889f305
😎 Deploy Preview https://deploy-preview-1163--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Coverage Status

coverage: 70.462% (-14.4%) from 84.868%
when pulling c90fc58 on feat/DS-1049-item-component
into f700adf on main.

@pavelklibani pavelklibani force-pushed the feat/DS-1049-item-component branch from c90fc58 to 138b3dd Compare November 23, 2023 09:08
@pavelklibani pavelklibani changed the base branch from main to feature/web-item November 23, 2023 09:08
@pavelklibani pavelklibani changed the base branch from feature/web-item to main November 23, 2023 09:09
@pavelklibani pavelklibani force-pushed the feat/DS-1049-item-component branch 2 times, most recently from d218f81 to 40ad87e Compare November 23, 2023 10:14
@pavelklibani pavelklibani marked this pull request as ready for review November 23, 2023 12:04
@pavelklibani pavelklibani force-pushed the feat/DS-1049-item-component branch from 5a83886 to 33d685c Compare November 23, 2023 12:25
@crishpeen crishpeen force-pushed the feat/DS-1049-item-component branch 2 times, most recently from 4f60314 to 4330224 Compare November 23, 2023 16:57
@crishpeen crishpeen changed the base branch from main to feature/web-item November 23, 2023 16:57
packages/web-react/src/components/Item/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Item/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Item/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Item/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Item/README.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 23, 2023

Coverage Status

coverage: 85.525% (+15.1%) from 70.462%
when pulling 3927b7f on feat/DS-1049-item-component
into 7bd2ae7 on integration/item.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update scripts/entryPoints as well. Otherwise good job 👍

@pavelklibani pavelklibani force-pushed the feat/DS-1049-item-component branch from 26204b9 to 2d28e67 Compare November 27, 2023 08:33
@pavelklibani
Copy link
Contributor Author

Please, update scripts/entryPoints as well. Otherwise good job 👍

Added, thank you!

@pavelklibani pavelklibani force-pushed the feat/DS-1049-item-component branch 2 times, most recently from 7234060 to be86547 Compare November 28, 2023 10:35
@pavelklibani pavelklibani reopened this Nov 28, 2023
Base automatically changed from feature/web-item to integration/item November 30, 2023 08:38
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove my commit from your branch :)

@pavelklibani pavelklibani force-pushed the feat/DS-1049-item-component branch from be86547 to 3927b7f Compare November 30, 2023 09:17
@pavelklibani pavelklibani merged commit 38a5f77 into integration/item Nov 30, 2023
20 checks passed
@pavelklibani pavelklibani deleted the feat/DS-1049-item-component branch November 30, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants