Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web, web-react): FileUploader error messages #1160

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 20, 2023

Description

  • FileUploader error messages changed to match across all packages
  • They are now formated like this: <filename>: <error message>

Additional context

image

Issue reference

FileUploader: nekonzistence v error hlášce

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit d625d23
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/655b3d5c1a429f0008d281e5
😎 Deploy Preview https://deploy-preview-1160--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit d625d23
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/655b3d5c957ace00080034b5

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d625d23
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/655b3d5c0bf2b70008fd4709
😎 Deploy Preview https://deploy-preview-1160--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2023
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit d625d23
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/655b3d5cff9b90000835563a
😎 Deploy Preview https://deploy-preview-1160--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Coverage Status

coverage: 70.462% (-14.4%) from 84.868%
when pulling d625d23 on fix/DS-1051-FU-max-file-size-error-message
into 4ccaf16 on main.

@pavelklibani pavelklibani marked this pull request as ready for review November 20, 2023 12:15
@literat literat requested a review from D0L1K November 20, 2023 14:15
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@pavelklibani pavelklibani merged commit 1d0d80f into main Nov 21, 2023
23 checks passed
@pavelklibani pavelklibani deleted the fix/DS-1051-FU-max-file-size-error-message branch November 21, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants