Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(design-tokens): Use sass condition in exports field #1158

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix(design-tokens): Use sass condition in exports field #1158

merged 1 commit into from
Nov 18, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Nov 16, 2023

Description

  • affects only Webpack
  • when the exports field is specified, only these module requests are available
  • any other requests will lead to a ModuleNotFound Error

Additional context

https://webpack.js.org/guides/package-exports/#conditions

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat
Fix(design-tokens): Use sass condition in exports field
cad6158 
  * affects only Webpack
  * @see https://webpack.js.org/guides/package-exports/#conditions
  * when the `exports` field is specified, only these module requests are available
  * any other requests will lead to a ModuleNotFound Error
@literat literat requested review from adamkudrna, crishpeen and a team as code owners November 16, 2023 15:45
@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit cad6158
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65563926c42160000831388a

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit cad6158
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65563926a052330008ba5cf6

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit cad6158
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/655639266b1f97000817fa94

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit cad6158
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/655639261b4acd00085017a5

@literat literat merged commit acc13ae into main Nov 18, 2023
20 checks passed
@literat literat deleted the fix/design-tokens-exports branch November 18, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen is a code owner

Assignees

@literat literat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@literat