Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Tabs styleProps #DS-977 #1155

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 15, 2023

Description

  • Added styleProps to TabsContent, TabItem, TabList and TabPane
  • UNSAFE_className and UNSAFE_style added to API tables for TabsContent, TabItem, TabList and TabPane

Additional context

Issue reference

React: Tabs nemají styleProps

- Added style props to TabsContent, TabItem, TabList and TabPane
- UNSAFE_className and UNSAFE_style added to API tables for
TabsContent, TabItem, TabList and TabPane
@pavelklibani pavelklibani self-assigned this Nov 15, 2023
@pavelklibani pavelklibani requested review from literat and a team as code owners November 15, 2023 15:06
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 4f4233a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65562564322d530008f50e18
😎 Deploy Preview https://deploy-preview-1155--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Nov 15, 2023
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 4f4233a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65562564e725df00093aa684

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4f4233a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6556256412bb7700087ef18f

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 4f4233a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6556256416832100088cca81
😎 Deploy Preview https://deploy-preview-1155--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Nov 15, 2023

Coverage Status

coverage: 84.868% (-11.6%) from 96.46%
when pulling 2057504 on fix/DS-977-tabs-styleprops
into 75a0272 on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add also tests for the styleProps :-)

@pavelklibani
Copy link
Contributor Author

Please, add also tests for the styleProps :-)

Tests added

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused code/commented code. Otherwise, it is looking good. Thanks.

@pavelklibani pavelklibani force-pushed the fix/DS-977-tabs-styleprops branch from 2057504 to 4f4233a Compare November 16, 2023 14:21
@pavelklibani pavelklibani merged commit 4ccaf16 into main Nov 20, 2023
19 checks passed
@pavelklibani pavelklibani deleted the fix/DS-977-tabs-styleprops branch November 20, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants