-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(web-react): Tabs styleProps #DS-977 #1155
Conversation
- Added style props to TabsContent, TabItem, TabList and TabPane
- UNSAFE_className and UNSAFE_style added to API tables for TabsContent, TabItem, TabList and TabPane
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add also tests for the styleProps :-)
Tests added |
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tabs/__tests__/TabList.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unused code/commented code. Otherwise, it is looking good. Thanks.
2057504
to
4f4233a
Compare
Description
styleProps
to TabsContent, TabItem, TabList and TabPaneUNSAFE_className
andUNSAFE_style
added to API tables for TabsContent, TabItem, TabList and TabPaneAdditional context
Issue reference
React: Tabs nemají styleProps