Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(repo): Remove lerna option for disabling verification #1154

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Chore(repo): Remove lerna option for disabling verification #1154

merged 1 commit into from
Nov 16, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Nov 15, 2023

Description

  • verify-access --verify-access=false and --no-verify-access are no longer needed
  • the legacy preemptive access verification is now disabled by default
  • requests will fail with appropriate errors when not authorized correctly

Additional context

Issue reference

refs #32

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat
Chore(repo): Remove lerna option for disabling verification
de22af8 
  * verify-access --verify-access=false and --no-verify-access are no longer needed
  * the legacy preemptive access verification is now disabled by default
  * requests will fail with appropriate errors when not authorized correctly

refs #32
@literat literat requested a review from a team as a code owner November 15, 2023 13:49
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit de22af8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6554cc63e4edd0000884eefd

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Nov 15, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit de22af8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6554cc63bd59e300086c655e

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit de22af8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6554cc63b1666f000887b44f

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit de22af8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6554cc63e4edd0000884ef02

@literat literat merged commit d08999a into main Nov 16, 2023
18 checks passed
@literat literat deleted the chore/lerna-verify-access branch November 16, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@literat literat

Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@literat