Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use httpS instead of http in SVG namespace #1151

Closed
wants to merge 5 commits into from

Conversation

literat
Copy link
Collaborator

@literat literat commented Nov 15, 2023

Description

Potential mixed content.

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Nov 15, 2023
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit d756cad
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6554bfee3d5e730008c8febf

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit d756cad
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6554bfeed151c8000810f75c

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit d756cad
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6554bfeeb315190008f097d0

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit d756cad
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6554bfeedd893100082166a3
😎 Deploy Preview https://deploy-preview-1151--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat
Copy link
Collaborator Author

literat commented Nov 15, 2023

🤔 maybe not -> w3c/svgwg#738

@pavelklibani
Copy link
Contributor

Can't see "check icons" in Checkbox component:
image

@literat literat closed this Nov 24, 2023
@literat literat deleted the refactor/mixed-content branch November 24, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants